cmd/subshell.go (1)

150-153: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick win

Consider capturing HAProxy stderr for diagnostics.

cmd.Stderr = nil discards all HAProxy error output. If HAProxy fails to bind or encounters config errors, there's no diagnostic information. Since cmd.Start() only verifies the process launched (not that it runs successfully), a silent startup failure would leave the user with a banner advertising a URL that doesn't work.

♻️ Proposed refactor: capture stderr for error reporting

 cmd := exec.Command("haproxy", "-f", configPath)
 cmd.Stdin = nil
 cmd.Stdout = nil
-cmd.Stderr = nil
+var stderr bytes.Buffer
+cmd.Stderr = &stderr
 
 if err := cmd.Start(); err != nil {
 	os.Remove(configPath)
 	return nil, "", fmt.Errorf("failed to start haproxy: %w", err)
 }
+// Give HAProxy a moment to fail on config/bind errors.
+time.Sleep(200 * time.Millisecond)
+if cmd.ProcessState != nil && cmd.ProcessState.Exited() {
+	os.Remove(configPath)
+	return nil, "", fmt.Errorf("haproxy exited immediately: %s", stderr.String())
+}
 
 centralDeploymentInfo.HAProxyPort = roxieConfig.HAProxy.BindPort

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@cmd/subshell.go` around lines 150 - 153, Update the HAProxy command setup
around exec.Command to capture stderr instead of discarding it, and use the
captured diagnostic output when cmd.Start or subsequent startup handling reports
failure. Preserve the existing stdin/stdout behavior while ensuring bind and
configuration errors are surfaced to the user rather than leaving a misleading
success banner.

cmd/main.go (1)

98-98: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Pass a pointer to mergo.Merge for consistency.

mergo.Merge expects the source argument to ideally be a pointer to avoid reflection overhead and potential type-matching issues. This also aligns with the usage in cmd/config.go and line 122 below.

♻️ Proposed fix

-			if err := mergo.Merge(config, configFromFile, mergo.WithOverride, mergo.WithoutDereference); err != nil {
+			if err := mergo.Merge(config, &configFromFile, mergo.WithOverride, mergo.WithoutDereference); err != nil {

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@cmd/main.go` at line 98, Update the mergo.Merge call in the
configuration-loading flow to pass configFromFile as a pointer, matching the
pointer-based usage in cmd/config.go and the nearby merge call while preserving
the existing override and WithoutDereference options.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes